Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Windows #101

Open
jfrimmel opened this issue Sep 22, 2024 · 3 comments · May be fixed by #102
Open

Remove support for Windows #101

jfrimmel opened this issue Sep 22, 2024 · 3 comments · May be fixed by #102

Comments

@jfrimmel
Copy link
Owner

Unless I'm mistaken, there is currently no suitable valgrind-binary available for Windows. Therefore I want to ask, whether this project should simply drop support for Windows at this point. Windows-binaries could either be entirely removed (and the code could even be un-compile-able on Windows) or the tool would simply forward to cargo <cmd> without any interventions (but this could trick somebody in thinking, that the code is fine, whereas in reality there are no checks done at all).

There was a project, that aims to make Valgrind working on Windows, but the last code change was done over 10 years ago. The project status is told to be pre-alpha and the last update to an open issue is from 2015. It is unclear to me, if it supports the XML-output required for cargo-valgrind, although the Windows port shares some of the codebase, hence it might be possible, although the CLI is nowhere documented. Therefore I don't think, that this is used on windows at the moment.

I'd like to hear if anyone actually uses this tool on Windows. If so, please comment under this issue.

@jfrimmel jfrimmel linked a pull request Sep 23, 2024 that will close this issue
@AlexanderSchuetz97
Copy link

I guess you could use drmemory instead on windows, it does mostly the same things, but well on windows. However that may aswell be its own crate.

@jfrimmel
Copy link
Owner Author

Thank you for your feedback. I'm not familiar with Dr. Memory, but I don't think, that it is "compatible" with valgrind (in the sense, that it supports the same flags and the same XML-based output format). If it is not compatible, it would be better to support it in a different tool, since cargo valgrind not calling valgrind may be confusing.

@AlexanderSchuetz97
Copy link

AlexanderSchuetz97 commented Oct 16, 2024

It was just a thought, I mainly user dr memory to find handle leaks. If this is just pure valgrind then drop windows support. Today I was looking for a way to automate this using dr memory. I knew of your crate and am using it for linux stuff....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants