Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in calculating if label fits inside bar for XYBarRenderer #366

Open
Yuri-Blankenstein-TNO opened this issue May 24, 2023 · 0 comments
Open

Bug in calculating if label fits inside bar for XYBarRenderer #366

Yuri-Blankenstein-TNO opened this issue May 24, 2023 · 0 comments

Comments

@Yuri-Blankenstein-TNO
Copy link

In the XYBar renderer its is checked if the label fits the inside of a bar to decide if it needs to be truncated or even not shown at all, see XYBarRenderer#calculateLabeltoDraw(...).
This method used the RectangularShape#contains(Rectangle2D) method, but this method takes the x,y offset into account which is not valid as only the dimensions of the rectangle should be considered.

This leads to strange effects like labels be positioned on their fallback locations or not shown at all.
Yuri-Blankenstein-TNO added a commit to Yuri-Blankenstein-TNO/jfreechart that referenced this issue May 24, 2023
@Yuri-Blankenstein-TNO
jfree#366 Bugfix for calculating if label fits inside bar
4a15402
Yuri-Blankenstein-TNO added a commit to Yuri-Blankenstein-TNO/jfreechart that referenced this issue May 24, 2023
@Yuri-Blankenstein-TNO
jfree#366 Updating README
7d6f3df
Yuri-Blankenstein-TNO added a commit to Yuri-Blankenstein-TNO/jfreechart that referenced this issue May 24, 2023
@Yuri-Blankenstein-TNO
Merge remote-tracking branch 'origin/bugfix/jfree#366' into
e463e67 
release/eclipse-orbit

Conflicts:
	README.md
Yuri-Blankenstein-TNO added a commit to Yuri-Blankenstein-TNO/jfreechart that referenced this issue May 24, 2023
@Yuri-Blankenstein-TNO
Merge remote-tracking branch 'origin/bugfix/jfree#366' into v1.5.x
d6705ec 
Conflicts:
	README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Yuri-Blankenstein-TNO