Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment about base branches on mainBranches config #3905

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abobov
Copy link

@abobov abobov commented Sep 10, 2024

  • PR Description

It took a while to find where to set up the base branch used for quick rebasing and viewing divergence, because it is no such thing as base branch in config.

Now it's easy to find a list of base branch names.

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

In rebase or upstream options menu `mainBranches` referenced as base
branch, now it's easy to find a place in config to update list of base
branch names.
@abobov
Copy link
Author

abobov commented Sep 10, 2024

We can change base branch to main branch, so there's no misunderstanding.

@@ -288,7 +288,7 @@ git:
# The commit message to use for a squash merge commit. Can contain "{{selectedRef}}" and "{{currentBranch}}" placeholders.
squashMergeMessage: Squash merge {{selectedRef}} into {{currentBranch}}

# list of branches that are considered 'main' branches, used when displaying commits
# list of branches that are considered 'main' branches (base branches), used when displaying commits
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally opposed to this if people find it helpful, but I do think that "main branches" is a better term to use here than "base branches". In my view, "base branch" is a term that only makes sense when talking about an individual feature branch ("what is the base branch of this feature branch?"). A repository's main branches is the set of branches that are used as base branches for other branches.

Maybe I'm splitting hairs here, but I did try to stick to this terminology in the UI so far. For example, the rebase and upstream menus in the commits panel talk about the "base branch"; I wouldn't use the term "main branch" there.

I wonder if there are any other ways to make this clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants