chore: checkstyle configuration and suggested updates #7003
Conversation
jeremylong
commented
Oct 1, 2024
•
jeremylong
commented
- fixes several checkstyle warnings
- add checkstyle back into PR workflow
- add spotbugs back into the PR workflow
boring-cyborg
bot
added
cli
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| * Example values: | ||
| * - binary "https://dl.google.com/geosdk/GoogleMaps.json" "7.2.0" | ||
| * - git "https://gitlab.matrix.org/matrix-org/olm.git" "3.2.16" | ||
| * - github "alinradut/SwiftEntryKit" "95f4a08f41ddcf2c02e2b22789038774c8c94df5"" | ||
| * - github "CocoaLumberjack/CocoaLumberjack" "3.8.5" | ||
| * - github "realm/realm-swift" "v10.44.0" | ||
| * Example values: - binary "https://dl.google.com/geosdk/GoogleMaps.json" | ||
| * "7.2.0" - git "https://gitlab.matrix.org/matrix-org/olm.git" "3.2.16" - | ||
| * github "alinradut/SwiftEntryKit" | ||
| * "95f4a08f41ddcf2c02e2b22789038774c8c94df5"" - github | ||
| * "CocoaLumberjack/CocoaLumberjack" "3.8.5" - github "realm/realm-swift" | ||
| * "v10.44.0" |
There was a problem hiding this comment.
@jeremylong Might be good to still post-merge review and correct occurrences like this in the delta that transformed 'nicely coded, but horribly rendered by Javadoc' to 'horribly coded, and horribly rendered by Javadoc' javadoc comments.
They should've been converted to proper HTML <ul> + <li> to be rendered as intended by the original written code rather than reformatted to have the bulleted items all rendered as 'standard javadoc text paragraph'
There was a problem hiding this comment.
I love autoformatting sometimes... Thanks for pointing this out.
