Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FP]: org.apache.ftpserver:ftpserver-core:jar is matched with apache mina #7043

Closed
davidweisgerber opened this issue Oct 14, 2024 · 2 comments
Labels
FP Report maven changes to the maven plugin

Comments

@davidweisgerber
Copy link

Package URl

pkg:maven/org.apache.ftpserver/[email protected]

CPE

cpe:2.3:a:apache:mina:1.2.0:::::::* (Confidence:Low)

CVE

CVE-2021-41973

ODC Integration

{"label"=>"Maven Plugin"}

ODC Version

10.0.4

Description

After #7026 (comment) was resolved, the package ftplet-api is now matched with apache mina. Interestingly, ftplet-core has a dependency to apache mina, but in another (patched) version: 2.1.6 which means I get the following false positive:

ftplet-api-1.2.0.jar (pkg:maven/org.apache.ftpserver/[email protected], cpe:2.3:a:apache:mina:1.2.0:::::::*) : CVE-2021-41973

Copy link
Contributor

Maven Coordinates

<dependency>
   <groupId>org.apache.ftpserver</groupId>
   <artifactId>ftplet-api</artifactId>
   <version>1.2.0</version>
</dependency>

Suppression rule:

<suppress base="true">
   <notes><![CDATA[
   FP per issue #7043
   ]]></notes>
   <packageUrl regex="true">^pkg:maven/org\.apache\.ftpserver/ftplet-api@.*$</packageUrl>
   <cpe>cpe:/a:apache:mina</cpe>
</suppress>

Link to test results: https://github.com/jeremylong/DependencyCheck/actions/runs/11321891338

@github-actions github-actions bot added the maven changes to the maven plugin label Oct 14, 2024
@aikebah
Copy link
Collaborator

aikebah commented Oct 16, 2024

As FTPServer is an independently managed subproject under the umbrella of the Apache MINA project it would indeed get a CPE separate from the MINA product assigned should a CVE get reported for it in the future, but the suppression suggested by the bot should not be used as it is very likely that NVD would opt for product mina-ftpserver (after the github repo) and the CPE suppression quoted would suppress it due to comparing using case-insensitive prefix matching.

<suppress base="true">
   <notes><![CDATA[
   FP per issue #7043
   ]]></notes>
   <packageUrl regex="true">^pkg:maven/org\.apache\.ftpserver/ftplet-api@.*$</packageUrl>
   <cpe regex="true">^cpe:/a:apache:mina:.*</cpe>
</suppress>

Should do the right suppression IIRC. I'll doublecheck that for proper working and will add it manually to the hosted suppressions (and update this comment should I discover that the suppression rule should be further adapted to be correct).

aikebah added a commit that referenced this issue Oct 16, 2024
@aikebah aikebah closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FP Report maven changes to the maven plugin
Projects
None yet
Development

No branches or pull requests

2 participants