Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Backup script not run automatically by operator #831

Open
dashashutosh24 opened this issue May 2, 2023 · 10 comments
Open

S3 Backup script not run automatically by operator #831

dashashutosh24 opened this issue May 2, 2023 · 10 comments
Assignees
Milestone

Comments

@dashashutosh24
Copy link

I have followed the instructions mentioned in : https://jenkinsci.github.io/kubernetes-operator/docs/getting-started/latest/custom-backup-and-restore/ and I have used the exact script given over here. But the backup script is neither run at pod termination nor at the given interval. But since the restore script is being run automatically by the operator, it is failing as there is no object in s3 bucket as the backup script didn't run. I have checked for connectivity to S3 and that is successfully working.
Screenshot 2023-05-02 at 11 09 27 AM
Screenshot 2023-05-02 at 11 10 03 AM
Screenshot 2023-05-02 at 11 10 24 AM
Screenshot 2023-05-02 at 11 10 37 AM

@brokenpip3
Copy link
Collaborator

I never tried that backup script.
We can try to official support it by adding it in the repo beside the pvc one and add some tests to be sure it will work correctly. Not a priority atm, if someone wants to try work on this will be super appreciated :)

@brokenpip3 brokenpip3 added the good first issue Good for newcomers label May 3, 2023
@brokenpip3 brokenpip3 added this to the 0.10 milestone May 3, 2023
@MackleX
Copy link

MackleX commented May 8, 2023

I am eager to contribute to the open-source community and would like to offer my assistance with the issue at hand. However, I am having difficulty understanding the specific requirements mentioned by @brokenpip3, particularly the reference to "the PVC one and add some tests." I have a general understanding of the issue, but I would greatly appreciate any additional guidance or clarification. I am excited to begin contributing to the Jenkins community, as they are known for supporting newcomers in tackling beginner-friendly issues.

@brokenpip3
Copy link
Collaborator

brokenpip3 commented May 8, 2023

I am having difficulty understanding the specific requirements mentioned by @brokenpip3, particularly the reference to "the PVC one and add some tests." I have a general understanding of the issue, but I would greatly appreciate any additional guidance or clarification.

Sorry, this is my bad.
As you can see here under backup/pvc https://github.com/jenkinsci/kubernetes-operator/tree/master/backup/pvc we have the pvc backup script that will do the classic backup by storing everything in the pvc that the helm chart create and mount in the jenkins pod.

By supporting the s3 I mean start creating the same structure under a backup/s3 dir to support the s3 backup option that is explained here: https://jenkinsci.github.io/kubernetes-operator/docs/getting-started/latest/custom-backup-and-restore/. With all the tests etc, and also changing the doc about this other backup options that we are going to have.
I can help with the testing/ci part.

(let me know if is not clear)

I am excited to begin contributing to the Jenkins community, as they are known for supporting newcomers in tackling beginner-friendly issues.

yeahhh!

do you want the issue assigned?

@MackleX
Copy link

MackleX commented May 9, 2023

that was clear and well explained from you part, thank you, and yes please i want the issue assigned.

@brokenpip3 brokenpip3 assigned brokenpip3 and MackleX and unassigned brokenpip3 May 9, 2023
@brokenpip3
Copy link
Collaborator

ehi @MackleX any news? do you need help in any way?

@MackleX
Copy link

MackleX commented Jun 28, 2023 via email

@brokenpip3
Copy link
Collaborator

sure no issue at all, you can do it even in 1 year, I was just checking if you need any helps from me :)

@qazifahad
Copy link

hi @MackleX,
I hope this message finds you well. . The problem described in the issue piqued my interest, especially since it's labeled as beginner-friendly. I am relatively new to the world of open-source contributions , and I'm eager to take on challenges that help me grow my skills. This particular issue seems like a fantastic opportunity for someone at my level to learn and make a meaningful contribution.
I was wondering if you would consider assigning this issue to me.
If you're open to this idea, I'd be grateful for the opportunity. Please let me know your thoughts or if there are any particular steps I should follow to get this issue assigned to me.
Thank you for considering my request. I appreciate your time and consideration.
cc @brokenpip3

@github-actions github-actions bot added the stale label Oct 8, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2023
@brokenpip3 brokenpip3 reopened this Oct 19, 2023
@brokenpip3
Copy link
Collaborator

@qazifahad looks good to me, @MackleX ?

Anyway any PR it will come it will be great :)

@qazifahad
Copy link

@brokenpip3 @dashashutosh24 can you guide me in replicating the issue at my end..any help would be appericiated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants