Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a longer password in the automated test #1656

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

MarkEWaite
Copy link
Contributor

Use a longer password in the automated test

There are cases where a longer password is better in the test. Example:

Testing done

Confirmed the test passes

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

jenkinsci/credentials-plugin#558 shows that
there are cases where a longer password is better in the test.
@MarkEWaite MarkEWaite requested a review from a team as a code owner September 17, 2024 17:02
@MarkEWaite MarkEWaite added the test Automated test addition or improvement label Sep 17, 2024
@github-actions github-actions bot added the tests Automated test addition or improvement label Sep 17, 2024
@MarkEWaite MarkEWaite removed the tests Automated test addition or improvement label Sep 17, 2024
@MarkEWaite MarkEWaite merged commit 9ba71f1 into jenkinsci:master Sep 17, 2024
17 checks passed
@MarkEWaite MarkEWaite deleted the use-longer-test-password branch September 17, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant