Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a copy button for the link examples #222

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Provide a copy button for the link examples #222

merged 1 commit into from
Aug 2, 2023

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Jul 31, 2023 •
edited
Loading

Provide a copy button for the link examples

Replace groovy pages with modernized jelly pages.

Use the copy button instead of an input field. The copy button is easier to understand and is used more and more often in Jenkins core.

Supersedes:

Testing done

Confirmed each URL in the new jelly pages matches the URL from the previous groovy pages.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Screenshots for comparison

Before this pull request

before

After this pull request

after

@MarkEWaite MarkEWaite added the enhancement Improvement or new feature label Jul 31, 2023
@MarkEWaite MarkEWaite marked this pull request as draft July 31, 2023 02:22
@MarkEWaite MarkEWaite marked this pull request as ready for review August 1, 2023 00:57
@MarkEWaite MarkEWaite changed the title Modernize view by replacing groovy with jelly Provide a copy button for the link examples Aug 1, 2023
@MarkEWaite MarkEWaite mentioned this pull request Aug 2, 2023
Closed
@MarkEWaite MarkEWaite linked an issue Aug 2, 2023 that may be closed by this pull request
Please add .adoc snippets #59
Closed
@MarkEWaite
Provide a copy button for link examples
f4a972b 
Use a more modern page layout with jelly instead of groovy layout.  Provide a copy button rather than using a borderless input field to provide easy copy and paste.  The copy button is used in multiple places in Jenkins.

Fix Bitbucket URL link error (Had unbalanced parentheses)

Add Asciidoc examples

Fixes jenkinsci#59
@MarkEWaite MarkEWaite force-pushed the replace-groovy-views-with-jelly branch from 1ea7547 to f4a972b Compare August 2, 2023 00:34
@MarkEWaite MarkEWaite merged commit 09dadb1 into jenkinsci:master Aug 2, 2023
15 checks passed
@MarkEWaite MarkEWaite deleted the replace-groovy-views-with-jelly branch August 2, 2023 15:05
@janfaracik janfaracik mentioned this pull request Dec 16, 2023
Merged
@MarkEWaite MarkEWaite mentioned this pull request Apr 13, 2024
Merged
@MarkEWaite
Copy link
Contributor Author

Introduced the following bug:

Bug fixed by:

@MarkEWaite MarkEWaite mentioned this pull request Apr 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please add .adoc snippets
1 participant
@MarkEWaite