Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove condition coverage necessity from branch coverage #134

Open
LorenzMende opened this issue Feb 16, 2022 · 0 comments
Open

remove condition coverage necessity from branch coverage #134

LorenzMende opened this issue Feb 16, 2022 · 0 comments

Comments

@LorenzMende
Copy link

Hi there,
we are working with sbt-scoverage and use the cobertura plugin for test result aggregation/ publishing.
I stumbled upon these lines in the parser:

if (Boolean.parseBoolean(attributes.getValue("branch"))) {
final String conditionCoverage = attributes.getValue("condition-coverage");
if (conditionCoverage != null) {
// some cases in the wild have branch = true but no condition-coverage attribute

Why is condition coverage data necessary for branch coverage parsing? Basically branch coverage and condition coverage are different by definition - and are only loosely coupled (branch coverage can be obtained without successful condition coverage).

I sincerely ask to update the functionality - I may create a PR for this issue if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant