true iff the given parameter is not null, and one of its
* reference parameters is the same parameter as this. In other words,
- * it returns whether or not the given parameter references this parameter.
+ * it returns whether the given parameter references this parameter.
*
* @since 0.22
* @param cascadeParameter {CascadeParameter} a given parameter
@@ -377,18 +376,18 @@ var UnoChoice = UnoChoice || ($ => {
this.cascadeParameter = cascadeParameter;
// Add event listener
let _self = this;
- $(this.paramElement).change(e => {
+ jQuery3(this.paramElement).change(e => {
if (e.parameterName === _self.paramName) {
console.log('Skipping self reference to avoid infinite loop!');
e.stopImmediatePropagation();
} else {
console.log(`Cascading changes from parameter ${_self.paramName}...`);
//_self.cascadeParameter.loading(true);
- $(".behavior-loading").show();
+ jQuery3(".behavior-loading").show();
// start updating in separate async function so browser will be able to repaint and show 'loading' animation , see JENKINS-34487
setTimeout(async () => {
- await _self.cascadeParameter.update(false);
- $(".behavior-loading").hide();
+ await _self.cascadeParameter.update(false);
+ jQuery3(".behavior-loading").hide();
}, 0);
}
});
@@ -441,18 +440,18 @@ var UnoChoice = UnoChoice || ($ => {
let parametersString = this.getReferencedParametersAsText(); // gets the array parameters, joined by , (e.g. a,b,c,d)
console.log(`Values retrieved from Referenced Parameters: ${parametersString}`);
// Update the Map of parameters
- await new Promise((resolve) => this.proxy.doUpdate(parametersString, t => resolve(t)));
+ await this.proxy.doUpdate(parametersString);
let parameterElement = this.getParameterElement();
let spinner, rootDiv;
if (parameterElement.id) {
let spinnerId = parameterElement.id.split('_').pop();
- spinner = jQuery(`div#${spinnerId}-spinner`);
+ spinner = jQuery3(`div#${spinnerId}-spinner`);
// Show spinner
if (spinner) {
spinner.show();
}
- rootDiv = jQuery(`div#${spinnerId}`);
+ rootDiv = jQuery3(`div#${spinnerId}`);
// Disable DIV changes
if (rootDiv) {
rootDiv.css('pointer-events', 'none');
@@ -462,9 +461,9 @@ var UnoChoice = UnoChoice || ($ => {
// or maybe call a string to put as value in a INPUT.
if (parameterElement.tagName === 'OL') { // handle OL's
console.log('Calling Java server code to update HTML elements...');
- await new Promise((resolve) => this.proxy.getChoicesForUI(t => {
- $(parameterElement).empty(); // remove all children elements
- let data = t.responseObject();
+ await this.proxy.getChoicesForUI(t => {
+ jQuery3(parameterElement).empty(); // remove all children elements
+ const data = t.responseObject();
console.log(`Values returned from server: ${data}`);
let newValues = data[0];
// let newKeys = data[1];
@@ -473,13 +472,12 @@ var UnoChoice = UnoChoice || ($ => {
li.innerHTML = newValues[i];
parameterElement.appendChild(li); // append new elements
}
- resolve(t)
- }));
+ });
} else if (parameterElement.tagName === 'UL') { // handle OL's
- $(parameterElement).empty(); // remove all children elements
+ jQuery3(parameterElement).empty(); // remove all children elements
console.log('Calling Java server code to update HTML elements...');
- await new Promise(resolve => this.proxy.getChoicesForUI(t => {
- let data = t.responseObject();
+ await this.proxy.getChoicesForUI(t => {
+ const data = t.responseObject();
console.log(`Values returned from server: ${data}`);
let newValues = data[0];
// let newKeys = data[1];
@@ -488,23 +486,20 @@ var UnoChoice = UnoChoice || ($ => {
li.innerHTML = newValues[i];
parameterElement.appendChild(li); // append new elements
}
- resolve(t)
- }));
+ });
} else if (parameterElement.id.indexOf('inputElement_') > -1) { // handle input text boxes
- await new Promise(resolve => this.proxy.getChoicesAsStringForUI(t => {
- parameterElement.value = t.responseObject();
- resolve(t)
- }));
+ await this.proxy.getChoicesAsStringForUI(t => {
+ parameterElement.value = JSON.stringify(t.responseObject());
+ });
} else if (parameterElement.id.indexOf('formattedHtml_') > -1) { // handle formatted HTML
- await new Promise(resolve => this.proxy.getChoicesAsStringForUI(t => {
+ await this.proxy.getChoicesAsStringForUI(t => {
parameterElement.innerHTML = t.responseObject();
- resolve(t)
- }));
+ });
}
// propagate change
// console.log('Propagating change event from ' + this.getParameterName());
// let e1 = $.Event('change', {parameterName: this.getParameterName()});
- // $(this.getParameterElement()).trigger(e1);
+ // jQuery3(this.getParameterElement()).trigger(e1);
if (!avoidRecursion) {
if (cascadeParameters && cascadeParameters.length > 0) {
for (let i = 0; i < cascadeParameters.length; i++) {
@@ -542,21 +537,21 @@ var UnoChoice = UnoChoice || ($ => {
this.originalArray = [];
// push existing values into originalArray array
if (this.paramElement.tagName === 'SELECT') { // handle SELECTS
- let options = $(paramElement).children().toArray();
+ let options = jQuery3(paramElement).children().toArray();
for (let i = 0; i < options.length; ++i) {
this.originalArray.push(options[i]);
}
} else if (paramElement.tagName === 'DIV' || paramElement.tagName === 'SPAN') { // handle CHECKBOXES
- if ($(paramElement).children().length > 0 && (paramElement.children[0].tagName === 'DIV' || paramElement.children[0].tagName === 'SPAN')) {
+ if (jQuery3(paramElement).children().length > 0 && (paramElement.children[0].tagName === 'DIV' || paramElement.children[0].tagName === 'SPAN')) {
let tbody = paramElement.children[0];
- let trs = $(tbody).find('div');
+ let trs = jQuery3(tbody).find('div');
for (let i = 0; i < trs.length ; ++i) {
- let tds = $(trs[i]).find('div');
- let inputs = $(tds[0]).find('input');
+ let tds = jQuery3(trs[i]).find('div');
+ let inputs = jQuery3(tds[0]).find('input');
let input = inputs[0];
this.originalArray.push(input);
}
- } // if ($(paramElement).children().length > 0 && paramElement.children[0].tagName === 'DIV') {
+ } // if (jQuery3(paramElement).children().length > 0 && paramElement.children[0].tagName === 'DIV') {
}
this.initEventHandler();
}
@@ -615,7 +610,7 @@ var UnoChoice = UnoChoice || ($ => {
*/
FilterElement.prototype.initEventHandler = function() {
let _self = this;
- $(_self.filterElement).keyup(e => {
+ jQuery3(_self.filterElement).keyup(e => {
//let filterElement = e.target;
let filterElement = _self.getFilterElement();
let filteredElement = _self.getParameterElement();
@@ -646,17 +641,17 @@ var UnoChoice = UnoChoice || ($ => {
let tagName = filteredElement.tagName;
if (tagName === 'SELECT') { // handle SELECT's
- $(filteredElement).children().remove();
+ jQuery3(filteredElement).children().remove();
for (let i = 0; i < newOptions.length ; ++i) {
let opt = document.createElement('option');
opt.value = newOptions[i].value;
opt.innerHTML = newOptions[i].innerHTML;
- $(filteredElement).append(opt);
+ jQuery3(filteredElement).append(opt);
}
} else if (tagName === 'DIV' || tagName === 'SPAN') { // handle CHECKBOXES, RADIOBOXES and other elements (Jenkins renders them as tables)
- if ($(filteredElement).children().length > 0 && ($(filteredElement).children()[0].tagName === 'DIV' || $(filteredElement).children()[0].tagName === 'SPAN')) {
+ if (jQuery3(filteredElement).children().length > 0 && (jQuery3(filteredElement).children()[0].tagName === 'DIV' || jQuery3(filteredElement).children()[0].tagName === 'SPAN')) {
let tbody = filteredElement.children[0];
- $(tbody).empty();
+ jQuery3(tbody).empty();
if (filteredElement.className === 'dynamic_checkbox') {
for (let i = 0; i < newOptions.length; i++) {
let entry = newOptions[i];
@@ -707,12 +702,12 @@ var UnoChoice = UnoChoice || ($ => {
tbody.appendChild(tr);
}
}
- } // if ($(filteredElement).children().length > 0 && $(filteredElement).children()[0].tagName === 'DIV') {
+ } // if (jQuery3(filteredElement).children().length > 0 && jQuery3(filteredElement).children()[0].tagName === 'DIV') {
} // if (tagName === 'SELECT') { // } else if (tagName === 'DIV') {
// Propagate the changes made by the filter
console.log('Propagating change event after filtering');
let e1 = $.Event('change', {parameterName: 'Filter Element Event'});
- $(filteredElement).trigger(e1);
+ jQuery3(filteredElement).trigger(e1);
});
}
// HTML utility methods
@@ -736,11 +731,11 @@ var UnoChoice = UnoChoice || ($ => {
* @see issue #21 in GitHub - github.com/biouno/uno-choice-plugin/issues
*/
function fakeSelectRadioButton(clazzName, id) {
- let element = $(`#${id}`).get(0);
+ let element = jQuery3(`#${id}`).get(0);
// deselect all radios with the class=clazzName
- let radios = $(`input[class="${clazzName}"]`);
+ let radios = jQuery3(`input[class="${clazzName}"]`);
radios.each(function(index) {
- $(this).attr('name', '');
+ jQuery3(this).attr('name', '');
});
// select the radio with the id=id
let parent = element.parentNode;
@@ -768,7 +763,7 @@ var UnoChoice = UnoChoice || ($ => {
* @return {string} the value of the HTML element used as parameter value in Jenkins, as a string
*/
function getParameterValue(htmlParameter) {
- let e = $(htmlParameter);
+ let e = jQuery3(htmlParameter);
let value = '';
if (e.attr('name') === 'value') {
value = util.getElementValue(e);
@@ -777,7 +772,7 @@ var UnoChoice = UnoChoice || ($ => {
if (subElements) {
let valueBuffer = Array();
subElements.each(function() {
- let tempValue = util.getElementValue($(this));
+ let tempValue = util.getElementValue(jQuery3(this));
if (tempValue)
valueBuffer.push(tempValue);
});
@@ -795,8 +790,101 @@ var UnoChoice = UnoChoice || ($ => {
return value;
}
+ // Hacks in Jenkins core
+ /**
+ * This function is the same as makeStaplerProxy available in Jenkins core, but executes calls + * synchronously. Since many parameters must be filled only after other parameters have been + * updated, calling Jenkins methods asynchronously causes several unpredictable errors.
+ * + *JENKINS-71909: Stapler had to be updated when Prototype and jQuery dependencies + * were removed from Jenkins. This means that we also had to update this function to + * match what was done there - thanks asc3ns10n (GH).
+ * + * @param url {string} The URL + * @param staplerCrumb {string} The crumb + * @param methods {ArrayJENKINS-71365 made Stapler proxy asynchronous and used JavaScript promises. This + * caused a regression where users could no longer render parameters in a deterministic + * way.
+ * + *To have proper asynchronous reactivity, we would have to either implement something + * akin to Vue or React's reactivity engine, since users would have to be able to declare + * how parameters react based on more elaborated constraints.
+ * + *This test uses the example from JENKINS-71909 to reproduce the bug.
+ * + * @since 2.8.4 + */ +@Issue("JENKINS-71909") +public class TestRevertingAsynchronousProxy extends BaseUiTest { + + @LocalData("test") + @Test + public void test() throws Exception { + // Load the page + driver.get(j.getURL().toString() + "job/test/build"); + + // From OP: + // + // The issue is when "Item2" is selected, then the 4) active-choice + // elements returns as selected "buster" instead of "bullseye", this + // because, when first called the wrong server list is returned from + // 3), because 3) is called with "a1" as parameter instead of "a2" + // as should be after the 2) gets executed. + + WebElement targetParam = findSelect("TARGET"); + assertTrue(targetParam.isDisplayed()); + assertTrue(targetParam.isEnabled()); + new Select(targetParam).selectByValue("Item2"); + + wait.until(ExpectedConditions.invisibilityOfElementLocated(By.cssSelector(".jenkins-spinner"))); + + List