Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage-badges-extension-plugin #3711

Closed
jonesbusy opened this issue Dec 27, 2023 · 15 comments
Closed

coverage-badges-extension-plugin #3711

jonesbusy opened this issue Dec 27, 2023 · 15 comments
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci security-audit-done The hosting request code passed the security audit with success

Comments

@jonesbusy
Copy link
Contributor

Repository URL

https://github.com/jonesbusy/coverage-badges-extension-plugin

New Repository Name

coverage-badges-extension-plugin

Description

Extension of embeddable-build-status-plugin that make it possible to create coverage metrics badges from coverage plugin. See README for details and usage

Original started by a question here : https://community.jenkins.io/t/how-to-use-embeddable-build-status-plugin-to-display-code-coverage/11463

GitHub users to have commit permission

@jonesbusy

Jenkins project users to have release permission

jonesbusy

Issue tracker

GitHub issues

@jonesbusy jonesbusy added the hosting-request Request to host a component in jenkinsci label Dec 27, 2023
@jenkins-cert-app
Copy link
Collaborator

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

  • /audit-ok => the audit is complete, the hosting can continue 🎉.
  • /audit-skip => the audit is not necessary, the hosting can continue 🎉.
  • /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

  • /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
  • /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.26.21)

@jenkins-cert-app jenkins-cert-app added the security-audit-todo The security team needs to audit the hosting request code label Dec 27, 2023
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: The 'artifactId' from the pom.xml (coverage-badges-extension-plugin) is incorrect, it should be coverage-badges-extension ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@jonesbusy
Copy link
Contributor Author

/hosting re-check

Copy link

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

@github-actions github-actions bot added bot-check-complete Automated hosting checks passed and removed needs-fix labels Dec 27, 2023
@jenkins-cert-app
Copy link
Collaborator

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉


💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

@jenkins-cert-app jenkins-cert-app added security-audit-done The hosting request code passed the security audit with success and removed security-audit-todo The security team needs to audit the hosting request code labels Dec 27, 2023
@MarkEWaite
Copy link
Contributor

+1 from me. I tested interactively and confirmed that it worked in the case that I tried.

@NotMyFault
Copy link
Member

Why isn't that a PR towards the embeddable-build-status plugin?

@MarkEWaite
Copy link
Contributor

Why isn't that a PR towards the embeddable-build-status plugin?

https://community.jenkins.io/t/how-to-use-embeddable-build-status-plugin-to-display-code-coverage/11463/4 says:

I originally open a PR on the Implement extension for code coverage badges by jonesbusy · Pull Request #280 · jenkinsci/embeddable-build-status-plugin · GitHub but I think it’s much better to create a new plugin to provide this extension. Specially if we need to provide more metrics.

@jonesbusy
Copy link
Contributor Author

@MarkEWaite Thanks.

@NotMyFault Also I don't want that the embeddable-build-status start to contains a lot of specific implementation and many optional plugin dependencies.

An example that I have in mind is the kubernetes-credentials-provider-plugin that contains a lot implementation for credentials management that nobody will use at the same time (Recent example is this PR jenkinsci/kubernetes-credentials-provider-plugin#94 and my comments)

In my opinion a plugin is better, embeddable-build-status already provide the extension point. Let's allow consumer use it

@NotMyFault
Copy link
Member

The <name> in the pom.xml should likely be changed. same as index.jelly :)

@NotMyFault
Copy link
Member

/hosting host

@jenkins-infra-bot
Copy link
Contributor

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/coverage-badges-extension-plugin

GitHub issues has been selected for issue tracking and was enabled for the forked repo.

A pull request has been created against the repository permissions updater to setup release permissions. Additional users can be added by modifying the created file.

Please delete your original repository (if there are no other forks), under 'Danger Zone', so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

In order for your plugin to be built by the Jenkins CI Infrastructure and check pull requests, please add a Jenkinsfile to the root of your repository with the following content:
https://github.com/jenkinsci/archetypes/blob/master/common-files/Jenkinsfile

Welcome aboard!

@jonesbusy
Copy link
Contributor Author

Thanks @NotMyFault

@jonesbusy
Copy link
Contributor Author

@MarkEWaite

Screenshot from 2023-12-28 21-09-36

Can you delete your forked repo ? Apparently GitHub automatically reattached the jenkinsci one to yours when I deleted mine... (Probably because you forked mine)

Thanks!

@MarkEWaite
Copy link
Contributor

@MarkEWaite
Can you delete your forked repo

Deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci security-audit-done The hosting request code passed the security audit with success
Projects
None yet
Development

No branches or pull requests

5 participants