Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subtitle burn settings for web player #1466

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Fix subtitle burn settings for web player #1466

merged 1 commit into from
Sep 1, 2024

Conversation

paulzzh
Copy link
Contributor

@paulzzh paulzzh commented Aug 14, 2024

Changes

Remove SubtitleProfiles override in nativeshell.js

Issues

Fix #1464

@jellyfin-bot jellyfin-bot added this to the v2.7.0 milestone Aug 14, 2024
Maxr1998
Maxr1998 approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@Maxr1998 Maxr1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Thanks for investigating this in the linked issue. I wasn't aware that the profiles are prefilled already. We can definitely remove this manual addition then.

@Maxr1998 Maxr1998 enabled auto-merge (squash) September 1, 2024 12:13
@Maxr1998 Maxr1998 merged commit 246f586 into jellyfin:master Sep 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maxr1998 Maxr1998 Maxr1998 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.

Forcing subtitle burning does not work on web player
3 participants
@paulzzh @Maxr1998 @jellyfin-bot