Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Reset" button in Filters in search doesn't work #1246

Open
FrankreedX opened this issue Sep 24, 2024 · 6 comments
Open

The "Reset" button in Filters in search doesn't work #1246

FrankreedX opened this issue Sep 24, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@FrankreedX
Copy link

Describe the bug

Go to the Search tab
click on any filter below the search bar
choose any filter
click on the "Reset" button
The previous choice will not be reverted

Application version

1.2 (4)

Where did you install the app from?

TestFlight

Device information

iPhone 11 Pro

OS version

iOS 18.0

Jellyfin server version

10.9.11

@FrankreedX FrankreedX added the bug Something isn't working label Sep 24, 2024
@FrankreedX
Copy link
Author

Ok it does work, but the drawer view does not update. Only when you exit will you see the change

@JPKribs
Copy link
Member

JPKribs commented Sep 24, 2024

Just tried testing this and I think this applies to both Library and Search filters. Are you seeing this as well?

@FrankreedX
Copy link
Author

Yes

@FrankreedX
Copy link
Author

O btw, I'm new to swift and contributing and would love to have this as my first ticket if possible. How do yall do that around here?

@JPKribs
Copy link
Member

JPKribs commented Sep 24, 2024

I'm absolutely not the authority for Swiftfin but I got started by looking at this: https://github.com/jellyfin/Swiftfin/blob/main/contributing.md

Then, I would make an In-Progress PR, from your fork, with this issue linked just so everyone knows what you're working on!

Always exciting to see new contributors!

@FrankreedX
Copy link
Author

Ok I thought this issue was simple but it's actually a web of Bindings that I'm still trying to wrap my head around... It probably has something to do with this warning though
Screenshot 2024-09-23 at 10 44 22 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants