tvOS Filters Implementation #1171
Closed
JPKribs
started this conversation in
Development
Replies: 1 comment
-
Please find the current version of this here: e9223c2 I like the layout of the filters but unfortunately, I am seeing some performance impacts from the:
Changing it to a:
Prevents the performance issue but an HStack at the top is only accessible when the cursor is at the top. The nested menu I currently have on this branch is accessible even if you've scrolled down. I'm up for any thoughts on getting this to work better! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hey all,
I was looking at adding the LetterPicker and Filters to tvOS. Currently, I see there are 3 items that I wanted to discuss before I proceeded. I want to not only make sure I am not stepping on any toes for this branch but also make sure that I am going about this in a way that makes sense from a layout perspective:
Focus - Moving the LetterPicker to tvOS and giving it focus-ability was straight forward enough but there are some weird, fun SwiftUI on tvOS interactions. Like, to move from the LetterPicker to the posters, you cannot jump directly from a letter that is below/above posters. You have to move to a letter on the same level as the posters to focus back to the posters. Lastly, the LetterPicker ALWAYS gets focused first on entry into the Library View because it's slightly taller than the library grid.
ItemTypeLibraryViewModel - A FilterModelView exists on all libraries in the Media tab of tvOS but the generic "Movies" & "TV Shows" Item Type grids have a different model view that do not have FilterModelViews on them. Do we want that to be the case? If not, I've had issues trying to add the FilterModelView onto the ItemTypeLibraryViewModel. What would be the best way to add a filter to this ItemTypeLibraryViewModel without just turning it into the same thing as ItemLibraryViewModel?
Filter Location - The logic to move the LetterPicker from Right to Left or remove it works on tvOS so that shouldn't be an issue but I was realizing there isn't a great place to put the filters. I came up with an idea to add it to the top of the LetterPicker but then the LetterPicker is always required? I could put it in the toolbar which works well for Library items but on the ItemTypeLibraryViewModel (See 2 Above) it pushes the library grid down so you only get ~2 rows of content. I've attached what my current version of this looks like.
Current Version
Simulator.Screen.Recording.-.Apple.TV.4K.3rd.generation.-.2024-08-07.at.15.10.01.mp4
Beta Was this translation helpful? Give feedback.
All reactions