Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navidrome Discord RPC icon support #552

Closed
flysqu opened this issue Mar 19, 2024 · 2 comments
Closed

Navidrome Discord RPC icon support #552

flysqu opened this issue Mar 19, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@flysqu
Copy link

flysqu commented Mar 19, 2024

What do you want to be added?

Currently discord rpc icons only work on jellyfin. Would be nice to have this on navidrome too. I understand if this is a unpassable limitation.

Additional context

This is the if statements responsible for this behaviour (Line 58 - 69)
https://github.com/jeffvli/feishin/blob/340344b791bbbed7f23ede2fb1d6170c22ebcef7/src/renderer/features/discord-rpc/use-discord-rpc.ts#L58C1-L69C10

This is a Navidrome specific feature

@flysqu flysqu added the enhancement New feature or request label Mar 19, 2024
@iiPythonx
Copy link
Contributor

iiPythonx commented Mar 19, 2024

Part of this limitation was discussed in #515 (comment), as sending the Navidrome image URL to discord would leak your credentials (as they're sent inside of the url). The main hurdle is still the fact that your Navidrome server would need to be publicly accessible, otherwise Feishin would need to use a service like imgur to act as a middleman.

@kgarner7
Copy link
Collaborator

kgarner7 commented Apr 1, 2024

Closing as duplicate of #341 (the comment from iiPythonx is still correct though).

@kgarner7 kgarner7 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants