New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hey should 'correct' only be if the final prediction was correct? Same for accuracy? #15

Open

colinator opened this issue Sep 19, 2020 · 1 comment

colinator commented Sep 19, 2020

Contrastive-Predictive-Coding-PyTorch/src/model/model.py

Line 100 in a9dab4e

    
           correct1 = torch.sum(torch.eq(torch.argmax(self.softmax(total), dim=0), torch.arange(0, batch))) # correct is a tensor

Meaning, should that correct variable be += ?

The text was updated successfully, but these errors were encountered:

NeteeraAF commented Jan 21, 2021

I noticed that too.

I think you're right, and after the loop over the timesteps, the sum should be divided by batch_size*num_of_timesteps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment