Python3 Support #94
Closed
Python3 Support #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just found a bug in real world use that did not show up in the testing. I am going to close this pull request. I want to (a) fix that bug and the (b) if I have time, figure out why the tests didn't catch it and fix that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #92 by encoding and decoding bytes/unicode
Added a wrapper tool so you can test python 2 and 3. It copies
git-fatand the tests. Changes the shebang ofgit-fatto the desired version. Add the updated version to the front of the bash path.Note that this does not work in 2.6 (as per #46) though the framework is there to test it easily.