Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for S3 as a storage backend #90

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

grahamgilbert
Copy link

This adds support for using AWS S3 as a backend via the AWS CLI tool. aws s3 sync is similar to rsync in operation, so it's a pretty simple drop in replacement.

Copy link
Owner

@jedbrown jedbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, thanks! Are there any mock aws tools such that we could write a test that doesn't require an S3 account to use? Also, could you add usage instructions to README.md?

@grahamgilbert
Copy link
Author

Whoops, I forgot to push the readme. I'm afraid I only know of tools that we can use for unit tests with actual python, not when we shell out to the AWS cli.

@delete-merged-branch delete-merged-branch bot deleted the s3 branch May 14, 2019 20:05
@jcftang
Copy link

jcftang commented Aug 30, 2019

you could mock s3 with moto

@natewalck
Copy link

Hey all! I was curious if anything else was needed for this to be merged. Its been a while, so not sure if there are more changed needed for this to function or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants