Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of projects added #357

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

sanketshevkar
Copy link

Number of projects under each category and under each programming language added. This is my first open-source contribution.

Description of number of projects.
added number of projects under each category and each programing language
Number of projects under each category and under each programming language included.
@jdm
Copy link
Owner

jdm commented Sep 3, 2019

So I think this is a good idea, but I don't think we should hardcode the strings that include the number of projects that are available. I would prefer to show something like "5/13" somewhere, if we are looking at project 5 out of 13 available for a given category. This would avoid any need to add additional strings that need localization, and we can calculate both numbers dynamically in javascript and update the DOM in this code.

@sanketshevkar
Copy link
Author

Okay cool. I'll start working on it. Thanks for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants