Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 1651: progress bar error state #1673

Merged
merged 15 commits into from
Mar 26, 2024

Conversation

bklimov-web
Copy link
Contributor

@bklimov-web bklimov-web commented Mar 10, 2024

@bklimov-web bklimov-web linked an issue Mar 11, 2024 that may be closed by this pull request
Copy link
Contributor

@Iogsotot Iogsotot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/jdi-testing/jdn-ai/assets/50149163/add31394-275b-4df6-a501-cb271a17f808
Возможно, баг связан с этим ПР, надо проверить.

По самой задаче - в проекте есть готовое решение аналогичного поведения для ProgressBar - LocatorProgres.tsx, мб получится взять логику оттуда и адаптировать для обработки ошибок в ProgressBar.tsx?

src/features/pageObjects/progressBar.slice.ts Outdated Show resolved Hide resolved
src/pageServices/pageDataHandlers.ts Outdated Show resolved Hide resolved
src/pageServices/pageDataHandlers.ts Show resolved Hide resolved
Copy link
Contributor

@Iogsotot Iogsotot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо за работу, выглядит очень хорошо!

@bklimov-web bklimov-web merged commit 40f39dd into master Mar 26, 2024
2 of 3 checks passed
@bklimov-web bklimov-web deleted the issue_1651-progress-bar-error-state branch March 26, 2024 18:03
@Iogsotot Iogsotot changed the title issue_1651 progress bar error state issue 1651: progress bar error state Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Medium] Notify the user when the backend fails
2 participants