Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Control Missing #21

Open
JasonMurrayCole opened this issue Apr 22, 2020 · 2 comments
Open

Tab Control Missing #21

JasonMurrayCole opened this issue Apr 22, 2020 · 2 comments

Comments

@JasonMurrayCole
Copy link

JasonMurrayCole commented Apr 22, 2020

The stylesheet lacks the Tab control. It's quite intricate in implementation, especially when rows are involved.

@CaptainFalcon92
Copy link
Contributor

Hello.
As a reference image i provide these.
It looks like depending on what windows these were used, they could also be justified left or in full width.

I think i can achieve this using display:flex.

Also see how the first only sits flush against the border when active.
Otherwise it has a slight left padding.

finddate01

GAz-YmKaYECM1Get-QhweeVYwEjPQfCL2FnVDynUH6ot5R3Pa8WlQuqJOqL-qw5lBtU3K-rZzkSyKOl7ci5h4Isf

@jdan
Copy link
Owner

jdan commented Apr 22, 2020

Good catch, this one was left on the cutting room floor :)

I'd happily support someone willing to build this in, the only caveat being that one of this project's goals is to be JavaScript-less, so while we could style a tabpanel (one which is annotated with the correct aria attributes), I wouldn't want to include any code to make it interactive - that would be left up to the users of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants