Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attempt resubmission if we get a HTTP 400 response #8

Open
Nick-Adams-AU opened this issue Jul 3, 2015 · 0 comments
Open

Don't attempt resubmission if we get a HTTP 400 response #8

Nick-Adams-AU opened this issue Jul 3, 2015 · 0 comments

Comments

@Nick-Adams-AU
Copy link
Contributor

I have identified an issue with Librato if I attempt to submit a metric where a composite metric by the same name already exists. This results in Librato returning a HTTP 400 error due to the name collision. statsd-librato identifies the non-HTTP-200 response and prints an error:

statsd 2015/07/03 09:05:02 unable to submit measurements: 400 Bad Request: {"errors":{"params":{"type":["'metric.restapi.requesttime' is a GAUGE, but was submitted as different type"]}},"request_time":1435878302}

Rather than statsd-librato moving on from the error, it appears to constantly attempt resubmission of the invalid data at each interval. New stats submissions don't occur as the erroneous data is constantly resubmitted until it is accepted - which of course it never will.

Temporary errors like HTTP 500/503..etc, should be reattempted but permanent errors such as HTTP 4xx should be logged, droped and we should move on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant