Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent separation of responsibilities between nord and openvpn #7

Open
jbweston opened this issue Sep 7, 2017 · 1 comment
Open

Comments

@jbweston
Copy link
Owner

jbweston commented Sep 7, 2017

At the moment we pass basically no flags to openvpn, which means that we have to handle many things in Python code (e.g. if we want some action to be performed when openvpn starts up or goes down, or we want to reconnect when the connection goes down).

However, openvpn itself has many flags that can control this behaviour (--up, --down, ...).
The advantage of using these flags is that it is less likely that bugs in nord will cause the system to be left in an inconsistent state (e.g. DNS settings not reset).

@jbweston jbweston changed the title Consistent about separation of responsibilities between nord and openvpn Consistent separation of responsibilities between nord and openvpn Sep 7, 2017
@jbweston
Copy link
Owner Author

jbweston commented Sep 9, 2017

As a part of this we should have a more clear separation of privileges also.

At the moment we need to be able to execute tee, cat, openvpn and kill under sudo.
If we tell OpenVPN to drop privileges (with the --user and --group flags) then we do not need sudo to kill the process. The disadvantage is that, as the openvpn process is a child of the sudo process that launched it we need to do some gymnastics to get the PID of the actual openvpn process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant