Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make application not only nord vpn specifiec #27

Open
hapylestat opened this issue May 30, 2018 · 2 comments
Open

Make application not only nord vpn specifiec #27

hapylestat opened this issue May 30, 2018 · 2 comments

Comments

@hapylestat
Copy link

Refactor code, to split NordAPI/OpenVPN/Application itself as self-sustained chunks of the application and let another people to write interfaces to their own VPN providers

@jbweston
Copy link
Owner

jbweston commented Jun 1, 2018

This is already quite separated. I think the only thing that depends on the NordVPN API itself is nord/api.py, which provides the Client class. Similarly, the OpenVPN part is entirely contained in nord/vpn.py.

When using the command line interface the choice of using the Nord client is currently hardcoded, but this would not be a very big change to have this configurable. The work would be writing a Client class that interacts with the VPN service of choice.

Did you have a particular one in mind?

@hapylestat
Copy link
Author

I thinking about PureVPN as it have better countries coverage, but currently i'm still nord user (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants