Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Runspace scoped registrations #3

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Use Runspace scoped registrations #3

merged 1 commit into from
Mar 21, 2024

Conversation

jborean93
Copy link
Owner

Move away from thread local storage for registrations to a new method that scopes the storage to a Runspace. This is because a Runspace where a module is loaded is not guaranteed to always run on the same thread breaking the previously registered forges.

Move away from thread local storage for registrations to a new method
that scopes the storage to a Runspace. This is because a Runspace where
a module is loaded is not guaranteed to always run on the same thread
breaking the previously registered forges.
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (78ff3c9) to head (b4e4e8b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #3       +/-   ##
===========================================
+ Coverage   69.12%   98.69%   +29.56%     
===========================================
  Files          12       12               
  Lines        1208     1223       +15     
  Branches      137      135        -2     
===========================================
+ Hits          835     1207      +372     
+ Misses        252        3      -249     
+ Partials      121       13      -108     
Flag Coverage Δ
PS_7.3_x64_Linux 98.69% <100.00%> (+29.56%) ⬆️
PS_7.3_x64_Windows 98.30% <100.00%> (+30.12%) ⬆️
PS_7.4_x64_Linux ?
PS_7.4_x64_Windows 98.64% <100.00%> (+30.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jborean93 jborean93 merged commit f528ca3 into main Mar 21, 2024
7 checks passed
@jborean93 jborean93 deleted the runspace-storage branch March 21, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant