Fix review link #24
Open
Fix review link #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just so I know, have you tested this change on Windows 8.0 and later? I ask because that block is using a IF WIN_RT conditional compile so it will apply to multiple builds. |
|
I don't have a Win8 machine to test on, but this is the best way I've found on Win10. One note: the "FamilyName" API which I use should work on Win8 and WinPhone8.1. What I'm not confident about is the URI scheme. Do you have a macro that can be used to version the URI scheme? https://msdn.microsoft.com/en-us/windows.applicationmodel.packageid.familyname |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launches the correct review page for the app. Previously this button just launched the Store without prompting for a review.