Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emojis are not displayed #5

Open
softveda opened this issue Aug 11, 2015 · 6 comments
Open

Emojis are not displayed #5

softveda opened this issue Aug 11, 2015 · 6 comments

Comments

@softveda
Copy link

emojivs - noicon

Emojis are not displayed.

@jbevain
Copy link
Owner

jbevain commented Aug 11, 2015

Given that Resharper hijacks its own Intellisense in Visual Studio, it's perfectly normal that Intellisense for emojis won't work without ReMoji /cc @hmemcpy.

Now, if:

  • The emojis are not displayed as images
  • The standard intellisense doesn't work

It suggests that Visual Studio simply didn't take the extension into account. I suggest first trying to restart Visual Studio, as extensions are not loaded upon installation.

If that didn't change anything, look into %USERNAME%\AppData\Local\Microsoft\VisualStudio\14.0Exp\Extensions\Jb Evain\EmojiVS\1.0

And see if there's a EmojiStore folder, and see if it has been populated with images.

Also it would help if you indicated which version of Visual Studio you are using.

@softveda
Copy link
Author

I could find a folder at %USERNAME%\AppData\Local\Microsoft\VisualStudio\14.0\Extensions\lfnhs4lk.2il
There is a EmojiStore folder but there are no images in there. I have restarted visual studio (2015), suspended/resumed resharper etc. As you can see in the screenshots the intellisense show the list of icons but when the comment text is entered it doesn't show as the icon but remains as text. Is there any logs that can be turned on? I am behind a corporate proxy.

@jbevain
Copy link
Owner

jbevain commented Aug 12, 2015

There's no logging right now. The easiest way is probably for you to build from source and debug through the lunch sequence.

@jbevain jbevain changed the title Doesn't work with Resharper installed Emojis are not displayed Aug 24, 2015
@atifaziz
Copy link

I think this might be related to proxy authentication (407) issue so images never download and EmojiStore remains empty.

@atifaziz
Copy link

I downloaded the images into EmojiStore, added the emojis.json file there too, restarted Visual Studio, and 💥, the emojis started working.

@atifaziz
Copy link

This extension should come with emojis pre-packaged and only try and update occasionally (e.g. once a day but certainly not on each initialization) and possibly only when explicitly requested through the options dialog in the IDE (though this could be addressed as a separate issue and come later). Also, I think that the update should happen via a separate executable that runs separate from the VS process. This would have the following benefits:

  1. It would make the extension more robust.
  2. The executable could be run to do the update out-of-band.
  3. The proxy issue would go away because the executable could have its own app.config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants