-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HistoricOneToOneField #1031
Comments
Hi, here's my implementation, basing on
|
Sorry I didn't see this when I opened issue #1389 |
No problem. We've been using it in production for over a year and I didn't experience any problems with it. Unfortunately I don't have enought free time to write propper tests and open a good pull request. |
So I am trying to write the pull request now. The
I think you should be returning here and not setting it to the variable "queryset". So I think you are always just getting the non-historical queryset because the super is always called. when I return instead, there are errors. So I am working on those now. |
Found it....you I think you needed |
@JordanHyatt , actually now you mentioned it, I checked and the final solution we use also returns the queryset instead assigning it and uses
|
That's funny, all 3 of those things I noticed and adjusted. See the PR I submitted. Thanks for posting, it definitely gave me a good headstart |
Great, haven't noticed it. Thanks for your work! |
Problem Statement
We have just gotten
HistoricForeignKey
which is great! It would be nice to have a similar forOneToOneField
.Describe the solution you'd like
Implementation of
HistoricOneToOneField
which does the same asHistoricForeignKey
just within the bounds of aOneToOneField
.The text was updated successfully, but these errors were encountered: