Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial shimmer setup on winning projects #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dorelljames
Copy link
Member

@dorelljames dorelljames commented Nov 1, 2024

Yay or nay?

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for hacktoberfest-jscebu ready!

Name Link
🔨 Latest commit fbc902b
🔍 Latest deploy log https://app.netlify.com/sites/hacktoberfest-jscebu/deploys/6724af6cb5820f00087fb2ef
😎 Deploy Preview https://deploy-preview-4--hacktoberfest-jscebu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@siegblink
Copy link

siegblink commented Nov 2, 2024

I don't think the shimmer effect should be placed around the card UI
I believe it's meant to be on placed CTA buttons

I'd like to see that shimmer effect placed around the "Submit your projects here" link (see screenshot)
But first, we must also do some adjustments on that element to make it stand out

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants