Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables #9

Merged
merged 6 commits into from
Jan 20, 2020
Merged

Variables #9

merged 6 commits into from
Jan 20, 2020

Conversation

JoeGab
Copy link
Contributor

@JoeGab JoeGab commented Jan 19, 2020

No description provided.

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Jan 19, 2020
@javascript-translate-bot javascript-translate-bot requested a review from a team January 19, 2020 04:22
@iliakan iliakan mentioned this pull request Jan 19, 2020
Open
@claassistantio
Copy link

claassistantio commented Jan 19, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JoeGab
Copy link
Contributor Author

JoeGab commented Jan 19, 2020

I didn't create the svg translations, wasn't sure if it is working for those? I also didn't translate the english code snippets except for the descriptional comments. Should I?

@iliakan
Copy link
Member

iliakan commented Jan 19, 2020

@JoeGab There's a special way to translate SVGs ;) We can do that later, when more text is ready for publishing.

@JoeGab
Copy link
Contributor Author

JoeGab commented Jan 19, 2020

okay cool! Let me know, I'll help =)

1H0
1H0 suggested changes Jan 20, 2020
View reviewed changes
1-js/02-first-steps/04-variables/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/04-variables/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/04-variables/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Jan 20, 2020
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@JoeGab
Copy link
Contributor Author

JoeGab commented Jan 20, 2020

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jan 20, 2020
@javascript-translate-bot javascript-translate-bot requested a review from a team January 20, 2020 11:59
@javascript-translate-bot javascript-translate-bot added needs +1 One more review needed and removed review needed Review needed, please approve or request changes labels Jan 20, 2020
@1H0 1H0 merged commit f707218 into javascript-tutorial:master Jan 20, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@1H0 1H0 added ready to merge and removed needs +1 One more review needed labels Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1H0 1H0 1H0 approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JoeGab @claassistantio @iliakan @javascript-translate-bot @1H0