Additional guidance on the PR process; Notes on using Docker to build a testing container #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added details describing pull request steps, and how to build a Jekyll environment using Docker. See issue 197 - More detailed guidance on how to build the Javalin documentation web site.
🗑 Deploy Preview for javalin.io deleted.
|
|
Thanks @northcoder-repo, this is great! Maybe you should include a comment about being able to preview the page when creating a PR:
For simple changes, this might be more practical than setting up everything locally. |
|
I never noticed that feature. I'll add a comment, yes. |
|
Great, thank you very much @northcoder-repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #197
Added notes to the CONTRIBUTING page for people like me who may be:
For the second point I have included a Dockerfile, and added notes on the commands needed to build a Docker image and run the container.