New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for programmatic-registration module is incorrect #320

Open

orelgenya opened this issue Sep 15, 2015 · 1 comment

Contributor

orelgenya commented Sep 15, 2015

This test wrong at many points:

test returns before calling ParentServlet, which is responsible for ChildServlet registration;
webclient calls wrong URLs (/ is redundant and don't match with mappings);
mapping for ChildServlet isn't set (dynamically)
fail(..) statement prevents execution of meaningful part of the test;
and finally it wouldn't work because programmatic registration is impossible after ServletContext initialization is finished.

Contributor

arun-gupta commented Sep 15, 2015

Send a PR with the fix?

orelgenya mentioned this issue

programmatic servlet registration fix #321

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment