Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if socket raises an exception that resource vanished, consider it closed #242

Merged
merged 1 commit into from
Dec 27, 2023
Merged

if socket raises an exception that resource vanished, consider it closed #242

merged 1 commit into from
Dec 27, 2023

Conversation

domenkozar
Copy link
Collaborator

Closes #232

@ysangkok
Copy link
Contributor

This would raise the minimum GHC required to 8.10 per https://wiki.haskell.org/Base_package and https://hackage.haskell.org/package/base-4.19.0.0/docs/System-IO-Error.html#v:isResourceVanishedError . The cabal file should be modified to reflect that.

ysangkok
ysangkok approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@ysangkok ysangkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if CHANGELOG entries are in PRs or on release. But otherwise this looks fine.

@domenkozar domenkozar merged commit f238132 into jaspervdj:master Dec 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysangkok ysangkok ysangkok approved these changes

@jaspervdj jaspervdj jaspervdj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IOException on Connection Reset but not documented
3 participants
@domenkozar @ysangkok @jaspervdj