Fix max column #5636
Merged
Fix max column #5636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Expend max_column in sqlite maybe not the best solution but yes it re-compiled will work as a temporary solution. so we can still track it in https://github.com/jasp-stats/INTERNAL-jasp/issues/2421#issuecomment-2097752605 Also this fix only works on macOS and Windows because we don't use conan on Linux? so a document and buildbot(for flatpak) update would be great. |
|
I'm adding a sqlite compile step to org.jaspstats.JASP separately now. |
3 tasks
JorisGoosen
pushed a commit
that referenced
this pull request
Sep 30, 2024
* add sqlite compile options to increase column limit * Fix CSV loader segfault --------- Co-authored-by: Rens <example>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix jasp-stats/jasp-issues#2837
But loading is still very slow