Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Throttle #5

Open
thejeff77 opened this issue Nov 25, 2019 · 2 comments
Open

Feature Request: Throttle #5

thejeff77 opened this issue Nov 25, 2019 · 2 comments

Comments

@thejeff77
Copy link
Collaborator

thejeff77 commented Nov 25, 2019

With large enough files and enough languages, this spams the API past its limit resulting in timeouts and reset connections.

To scale well, I recommend supporting bulk translations - x at a time.

Second, if requests are throttled to one at a time, or have a pool with a maximum number of executors would help keep requests constant over time, rather than scaling up rapidly to handle all input at once.

@thejeff77
Copy link
Collaborator Author

Thanks for the invite. Looks like throttling wouldn't be too bad - the async library you use has a queue function if you search "### queue(worker, [concurrency])" on v1.5 https://github.com/caolan/async/blob/v1.5.2/README.md

@thejeff77 thejeff77 changed the title Feature Request: Do bulk translations, & throttle Feature Request: Throttle Nov 25, 2019
@thejeff77
Copy link
Collaborator Author

#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant