Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI pipeline #271

Merged
merged 10 commits into from
Jan 29, 2024
Merged

Update CI pipeline #271

merged 10 commits into from
Jan 29, 2024

Conversation

trin94
Copy link
Contributor

@trin94 trin94 commented Jan 26, 2024

Hey, this pull request is just some maintenance work on the pipeline. The commits should speak for themselves. Feel free to squash them when you merge. Best regards 😄

Using pytest, we run into access violation errors on Windows.
They disappear when we use the unittest module.
Using pytest, we run into access violation errors on Windows.
They disappear when we use the unittest module.
@jaseg
Copy link
Owner

jaseg commented Jan 29, 2024

Thank you very much! Looks good to me.

For the record: This PR adds the pull_request trigger to the workflow. I did a cursory check, and as far as I can tell this is okay and will hopefully not cause any security issues because the pull_request trigger runs the workflow under the PR author's fork, not ours. The pull_request trigger is different from the pull_request_target trigger.

@jaseg jaseg merged commit d26f801 into jaseg:main Jan 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants