Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sxiv is dead, maybe add support for nsxiv? #1229

Closed
tonijarjour opened this issue Nov 10, 2021 · 1 comment · Fixed by #1230
Closed

sxiv is dead, maybe add support for nsxiv? #1229

tonijarjour opened this issue Nov 10, 2021 · 1 comment · Fixed by #1230

Comments

@tonijarjour
Copy link
Contributor

The sxiv repo has been archived and people have discussed continuing development --> xyb3rt/sxiv#463
The new repo is here --> https://github.com/nsxiv/nsxiv
I do not mind either way. But I just wanted to tell you about this. It may be worth having the code use either sxiv or nsxiv, depending on which is available.
@N-R-K
Copy link
Collaborator

N-R-K commented Nov 10, 2021

I don't think nnn bothers with images or image viewers. Running a grep on the repo, there's only 3 plugins that are using sxiv right now, nuke, preview-tabbed and imgview. Should not be too difficult to add nsxiv support on them. I'll look into it.

N-R-K added a commit to N-R-K/nnn that referenced this issue Nov 10, 2021
@N-R-K
add nsxiv support to nuke, preview-tabbed and imgview
3adbd2f 
Closes: jarun#1229
N-R-K added a commit to N-R-K/nnn that referenced this issue Nov 10, 2021
@N-R-K
add nsxiv support to nuke, preview-tabbed and imgview
39a3cc5 
`nuke` and `preview-tabbed` works as expected. I would assume `imgview`
should work as expected as well since `nsxiv` (at the moment at least)
is a drop-in replacement for sxiv, but I haven't tested it.

Closes: jarun#1229
@N-R-K N-R-K mentioned this issue Nov 10, 2021
Merged
KenJean pushed a commit to KenJean/nnn that referenced this issue Nov 23, 2021
@N-R-K
add nsxiv support to nuke, preview-tabbed and imgview
aba1364 
`nuke` and `preview-tabbed` works as expected. I would assume `imgview`
should work as expected as well since `nsxiv` (at the moment at least)
is a drop-in replacement for sxiv, but I haven't tested it.

Closes: jarun#1229
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add nsxiv support to nuke, preview-tabbed and imgview N-R-K/nnn
2 participants
@tonijarjour @N-R-K