Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability in dependencies (openid -> request) #47

Open
ZissisT opened this issue Jun 1, 2020 · 1 comment
Open

Vulnerability in dependencies (openid -> request) #47

ZissisT opened this issue Jun 1, 2020 · 1 comment

Comments

@ZissisT
Copy link

ZissisT commented Jun 1, 2020

Hello,

right now passport-openid depends on openid module -> depends on request@^2.61.0 which has a memory leak vulnerability (request/request#2938) .

I opened a ticket there but this module seems abandoned, havard/node-openid#175 so I don't think that this will be fixed there, soon.
Unfortunately there is no openid version (not even v2) that has this fixed, so I don't know how this could be fixed with passport-openid (maybe depend on a different module, other than openid ? )

Thank you

@YasharF
Copy link

YasharF commented Jul 10, 2020

It might be worth for passport-openid to migrate from the openid package to the better-maintained node-openid-client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants