Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "moved" status to "replaced", to make it more generic #26

Open
waldyrious opened this issue Jul 30, 2018 · 3 comments
Open

Rename "moved" status to "replaced", to make it more generic #26

waldyrious opened this issue Jul 30, 2018 · 3 comments

Comments

@waldyrious
Copy link

As discussed in #19 (particularly from this comment onwards), switching from "moved" to "replaced" would support a wider variety of real-world statuses, without significant loss of clarity.

This change would allow the status to cover, for example:

  • projects that are renamed within the same platform
  • projects that are moved to a different platform
  • projects that are superseded by more comprehensive or more actively maintained ones
@jantman
Copy link
Owner

jantman commented Jul 30, 2018

I think this makes sense to me. I don't really have any projects that these new use cases cover, so I'll defer to consensus of interested parties on this. My own needs from RepoStatus are pretty simple, so at this point I'm mainly just managing PRs and community consensus.

Assuming we want to make this switch, I'll have to think about how to handle and communicate a rename of one of the statuses...

@Alarm-Siren
Copy link

I agree that "Replaced" is a better general-purpose name for the purposes as articulated by @waldyrious

In terms of managing the switch over, I would suggest just make Moved and Replaced the same thing semantically; Moved is deprecated and Replaced is recommended, but ultimately they mean the same thing. Its probably unrealistic to get everyone to "upgrade" to Replaced anyway, particularly for older repos that have been long since forgotten.

@Relequestual
Copy link

Coming here to note that I'd also value "replaced".
In terms of making such an change having as least friction as possible, allowing both seems like a viable solution with the same semantics, and just let the end user choose which they prefer.

I'm happy to make a PR for this if that's helpful, although I probably won't see notifications for some time =]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants