De-activating Account should remove Plaid link

[ripnyt-ripnyt]

Bug Report

When reporting a bug, please provide all of the following information,
as well as any additional details that may be useful in reproducing or fixing
the issue:

Version

1.1.1+git.130935c4

biweeklybudget version, as reported by biweeklybudget --version

Installation Method

Docker inside NixOS, with MariaDB in Docker

Supporting Software Versions

Python 3.10.8
Docker w/o root access
NixOS 22.11,
Client:
Context: default
Debug Mode: false
Plugins:
buildx: Docker Buildx (Docker Inc., v0.9.1)
compose: Docker Compose (Docker Inc., 2.12.2)

Server:
Containers: 4
Running: 2
Paused: 0
Stopped: 2
Images: 3
Server Version: 20.10.21
Storage Driver: overlay2
Backing Filesystem: extfs
Supports d_type: true
Native Overlay Diff: true
userxattr: false
Logging Driver: journald
Cgroup Driver: systemd
Cgroup Version: 2
Plugins:
Volume: local
Network: bridge host ipvlan macvlan null overlay
Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
Swarm: inactive
Runtimes: io.containerd.runc.v2 io.containerd.runtime.v1.linux runc
Default Runtime: runc
Init Binary: docker-init
containerd version: v1.6.10
runc version:
init version:
Security Options:
seccomp
Profile: default
cgroupns
Kernel Version: 5.15.85
Operating System: NixOS 22.11 (Raccoon)
OSType: linux
Architecture: x86_64
CPUs: 16
Total Memory: 31.23GiB
Name: nixos
ID: CFKI:JFF6:F64L:CZHK:K5UE:ADO7:QIX3:VNG7:U2IF:5UAY:YW4N:EK25
Docker Root Dir: /var/lib/docker
Debug Mode: false
Registry: https://index.docker.io/v1/
Labels:
Experimental: false
Insecure Registries:
127.0.0.0/8
Live Restore Enabled: true

Actual Output

just that when i wanted to move a cc account from a bank account category to credit card category, I archived the account prior to disconnecting it from plaid. this prevented me from linking it to another account, but i couldn't find how to restore it from archive in the UI.

Expected Output

Be able to restore an account from archive with UI

Testing Assistance

Sure, if done with container.

[ripnyt-ripnyt]

add on: if you name an account with identical then fails silently.

[jantman]

@ripnyt-ripnyt Thanks for reporting this, and apologies for the delayed response.

Regarding the duplicate account name bug, I've opened #275 to track that but have no idea when I'll get around to fixing it.

Regarding the main issue here, it looks like there are actually two:

1. There's no way to re-activate an Account through the UI. I've opened another issue, Inability to re-activate an Account #276 for this. That issue contains a workaround of directly updating the database to re-enable the account.
2. Yes, de-activating an account should definitely remove the Plaid link. I've updated the title of this issue accordingly, but I have no idea when I will get around to implementing that.