Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hypothesis Integration - Does Not Work Well With epub.min.js v.0.3.93 #3105

Open
minh-p opened this issue Jul 19, 2024 · 3 comments
Open

Hypothesis Integration - Does Not Work Well With epub.min.js v.0.3.93 #3105

minh-p opened this issue Jul 19, 2024 · 3 comments

Comments

@minh-p
Copy link

minh-p commented Jul 19, 2024

Hello. First, I would like to thank the community and its maintainer OzzieIsaacs for Calibre-Web.
My friends and I have been enjoying our new free and open source independent knowledge repository.

Describe the bug/problem
Hypothesis annotation/highlight feature fails to work with epub.min.js v. 0.3.93 (for EPUB v.2 books).
Downgrading to futurepress's release v.0.3.88 enabled it to work flawlessly.

To Reproduce

Steps to reproduce the behavior:

  1. Use Chromium-based Browser (I used Brave).
  2. Download Hypothesis - Web & PDF Annotations chrome extension.
  3. Try annotating on Calibre-web EPUB web reader. --> Highlight/Annotation Menu fails to appear after highlighting text.

Some Clarifications

  1. Is this my system's problem? Most likely not as I ran it both locally (running arch linux) and on my Oracle Cloud server (running ubuntu).
  2. Installation Process? According to Manual Installation Guide.
  3. Any problems with epub.min.js on v.0.3.88? It doesn't seem so: TOC, Full screen, Text UI adjustment, Full Screen all seems to work.

Proposal
Add this to README.md perhaps?

@minh-p minh-p changed the title Hypothesis.js Does Not Work With epub.min.js v.0.3.93 Hypothesis Does Not Work With epub.min.js v.0.3.93 Jul 19, 2024
@minh-p
Copy link
Author

minh-p commented Jul 20, 2024

Hello, if you're wondering how to embed Hypothesis into the EPUB web reader, here is a diff from my fork showing how I did it:
1fdc7ca
Furthermore, to read annotate well on mobile, I disabled swipe: 4532189

@minh-p
Copy link
Author

minh-p commented Jul 20, 2024

It works well on PC as well FYI.
Screenshots of Hypothesis working on mobile (PWA bookmarked for individual web reader link):
Closed

Half-View

@minh-p minh-p changed the title Hypothesis Does Not Work With epub.min.js v.0.3.93 Hypothesis Integration - Does Not Work Well With epub.min.js v.0.3.93 Jul 20, 2024
@minh-p
Copy link
Author

minh-p commented Jul 20, 2024

As well, here's my fork if anyone's interested: https://github.com/minh-p/calibre-web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant