Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserService.link called when only using one oauth2 provider #515

Open
lukestephenson opened this issue Jan 26, 2015 · 1 comment
Open

UserService.link called when only using one oauth2 provider #515

lukestephenson opened this issue Jan 26, 2015 · 1 comment

Comments

@lukestephenson
Copy link
Contributor

I'm only making use of the the linkedin oauth2 provider and not allowing any other providers. As such, I didn't bother to implement UserService.link as the there is no need to link accounts. I was so confident that this method wouldn't be called, that it throws an Exception if it is called.

However, if the user is already logged in, and they hit http://website/authenticate/linkedin directly, then the UserService.link method is invoked.

I'm not to fussed if the behaviour changes or not, but if it remains as is then I think it's worth updating the UserService documentation to warn that link may be called even if only one provider is used.

@gmethvin
Copy link
Contributor

We definitely should continue to support multiple of each account type. I'm using this functionality to connect multiple Google accounts and combine data from all of them. If you don't want to allow linking multiple linkedin accounts, you need to explicitly implement the link method to make sure that happens.

The documentation should probably make it clear that SecureSocial supports linking any number of accounts, of any type, together into one user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants