Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra-attributes suggestion! #44

Open
PxlSyl opened this issue Apr 29, 2022 · 5 comments
Open

Extra-attributes suggestion! #44

PxlSyl opened this issue Apr 29, 2022 · 5 comments

Comments

@PxlSyl
Copy link
Collaborator

PxlSyl commented Apr 29, 2022

Hi again,

I don't know if there's a way to code what is in my head lol

But perhaps you noticed there's an "extra-attributes" feature in NFTchef repository, and with that we can add and customize "numbers" traits with the random.math function in many ways.

But is there a way to code a script (or an util script) which gives a specific number value for a given (layer) trait?

Could be great for gaming : rares/legendary NFTs with extra-power, or extra-speed for example!

@jalagar
Copy link
Owner

jalagar commented Apr 30, 2022

Hi I haven't seen the extra-attributes feature in NFTchef let me put it in the backlog and look into it later!

@PxlSyl
Copy link
Collaborator Author

PxlSyl commented Apr 30, 2022

Line 121 here in the config file :
https://github.com/nftchef/art-engine/blob/nested-folder-structure/src/config.js

@jalagar
Copy link
Owner

jalagar commented May 8, 2022

@PxlSyl extra-attributes works out of the box, you can find it in step2/config.js. I just tested it, it works. In terms of adding specific traits for specific rares/legendaries, you would probably want to use the replace legendary feature https://github.com/jalagar/Generative_Gif_Engine#randomly-insert-rare-items---replace-util and create the configs yourself, or you can generate just rares/legendaries first with extraAttributes with another Math.random or something. I can keep this open but there are a few workarounds

@PxlSyl
Copy link
Collaborator Author

PxlSyl commented May 9, 2022

Yeah I know it works as it is :) For the replace feature, it's not sufficient. Of course I will use it for handmade legendaries, writing the json manually. But the point and the goal are not there, in fact in a normal collection there are several degrees of rarity (apart from the legendaries which have nothing to do ^^) and there the goal would therefore be a utility script which allows to look if layer "x" is present in "y" json, then such math.random function should apply to add a specific number trait . I think for this you would need a js script, and a configuration file for this script, let me know what do you think? I know some other people are looking for the same thing! And perhaps some devs I know will implement this but IDK for now

@jalagar
Copy link
Owner

jalagar commented May 12, 2022

Got it that makes sense! I think that seems almost like a separate tool that could parse the JSONs and then append a random rarity. I would ask in Hashlips discord, someone might have wrote it for you. You don't even need it to be a part of this tool because its not directly related to GIFs and can be something added afterwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants