Revert "Fix #525 FlushBufferTest" #756

pmd1nh · 2024-11-08T18:27:16Z

Reverts #680

Hi,

The change in PR 680 has completely removed the old test, which has been around in many releases, and replaced with two new tests. If the community thinks that the previous/old test is invalid, it should be excluded in the Servlet TCK 6.1.1. Any new or replacement tests need to be added to the next servlet release.

PR 680 doesn’t follow the service release policy and needs to be reverted.

Bumps [jakarta.annotation:jakarta.annotation-api](https://github.com/jakartaee/common-annotations-api) from 2.1.1 to 3.0.0. - [Commits](jakartaee/common-annotations-api@2.1.1...3.0.0) --- updated-dependencies: - dependency-name: jakarta.annotation:jakarta.annotation-api dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.junit.jupiter:junit-jupiter-params](https://github.com/junit-team/junit5) from 5.10.1 to 5.10.2. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.10.1...r5.10.2) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter-params dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [jakarta.tck:sigtest-maven-plugin](https://github.com/eclipse-ee4j/jakartaee-tck-tools) from 2.2 to 2.3. - [Release notes](https://github.com/eclipse-ee4j/jakartaee-tck-tools/releases) - [Commits](eclipse-ee4j/jakartaee-tck-tools@sigtest-2.2...sigtest-2.3) --- updated-dependencies: - dependency-name: jakarta.tck:sigtest-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps net.revelc.code:impsort-maven-plugin from 1.9.0 to 1.10.0. --- updated-dependencies: - dependency-name: net.revelc.code:impsort-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps org.jruby:jruby-complete from 9.3.13.0 to 9.3.14.0. --- updated-dependencies: - dependency-name: org.jruby:jruby-complete dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.asciidoctor:asciidoctorj-pdf](https://github.com/asciidoctor/asciidoctorj-pdf) from 2.3.15 to 2.3.17. - [Release notes](https://github.com/asciidoctor/asciidoctorj-pdf/releases) - [Changelog](https://github.com/asciidoctor/asciidoctorj-pdf/blob/main/CHANGELOG.adoc) - [Commits](asciidoctor/asciidoctorj-pdf@v2.3.15...v2.3.17) --- updated-dependencies: - dependency-name: org.asciidoctor:asciidoctorj-pdf dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps net.revelc.code.formatter:formatter-maven-plugin from 2.23.0 to 2.24.1. --- updated-dependencies: - dependency-name: net.revelc.code.formatter:formatter-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

* Prepare release jakarta.servlet:servlet-parent:6.1.0 * Prepare next development cycle for 6.1.1-SNAPSHOT * Update lingering 6.1.0 references (#655) Signed-off-by: Arjan Tijms <[email protected]> --------- Signed-off-by: Arjan Tijms <[email protected]> Co-authored-by: Eclipse Servlet Bot <[email protected]>

Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.2.5 to 3.3.0. - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.2.5...surefire-3.3.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-surefire-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…ven.plugins-maven-surefire-plugin-3.3.0

Fix #616 - avoid NPE

Bumps org.jruby:jruby-complete from 9.3.14.0 to 9.3.15.0. --- updated-dependencies: - dependency-name: org.jruby:jruby-complete dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.junit.jupiter:junit-jupiter-params](https://github.com/junit-team/junit5) from 5.10.2 to 5.10.3. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.10.2...r5.10.3) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter-params dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps net.revelc.code:impsort-maven-plugin from 1.10.0 to 1.11.0. --- updated-dependencies: - dependency-name: net.revelc.code:impsort-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.junit.jupiter:junit-jupiter-engine](https://github.com/junit-team/junit5) from 5.10.2 to 5.10.3. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.10.2...r5.10.3) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter-engine dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.10.2 to 5.10.3. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.10.2...r5.10.3) --- updated-dependencies: - dependency-name: org.junit:junit-bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Move unit tests to ee.jakarta

… Maven plugins/configuration (#676) (#677) Signed-off-by: Olivier Lamy <[email protected]>

Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.3.0 to 3.3.1. - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.3.0...surefire-3.3.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-surefire-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.jboss.arquillian:arquillian-bom](https://github.com/arquillian/arquillian-core) from 1.8.0.Final to 1.9.0.Final. - [Release notes](https://github.com/arquillian/arquillian-core/releases) - [Commits](arquillian/arquillian-core@1.8.0.Final...1.9.0.Final) --- updated-dependencies: - dependency-name: org.jboss.arquillian:arquillian-bom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…ven.plugins-maven-surefire-plugin-3.3.1

…uillian-arquillian-bom-1.9.0.Final

Bumps [org.jboss.arquillian:arquillian-bom](https://github.com/arquillian/arquillian-core) from 1.9.0.Final to 1.9.1.Final. - [Release notes](https://github.com/arquillian/arquillian-core/releases) - [Commits](arquillian/arquillian-core@1.9.0.Final...1.9.1.Final) --- updated-dependencies: - dependency-name: org.jboss.arquillian:arquillian-bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

* Fix #525 FlushBufferTest Replace the disputed test (that tests poorly defined behaviour of a bad servlet) with two tests that check the accepted behaviour of a well written servlet. Once there is an accepted interpretation of the behaviour for the bad servlet, additional tests can be added to check that.

…nit.jupiter-junit-jupiter-engine-5.11.3

…nit-junit-bom-5.11.3

…nit.jupiter-junit-jupiter-params-5.11.3

…ciidoctor-asciidoctorj-pdf-2.3.19

Signed-off-by: James R. Perkins <[email protected]>

Align copyright header with rest of project

Bumps `shrinkwrap-resolver.version` from 3.3.1 to 3.3.2. Updates `org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-api-maven` from 3.3.1 to 3.3.2 - [Release notes](https://github.com/shrinkwrap/resolver/releases) - [Commits](shrinkwrap/resolver@3.3.1...3.3.2) Updates `org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-spi-maven` from 3.3.1 to 3.3.2 - [Release notes](https://github.com/shrinkwrap/resolver/releases) - [Commits](shrinkwrap/resolver@3.3.1...3.3.2) Updates `org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-impl-maven` from 3.3.1 to 3.3.2 - [Release notes](https://github.com/shrinkwrap/resolver/releases) - [Commits](shrinkwrap/resolver@3.3.1...3.3.2) --- updated-dependencies: - dependency-name: org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-api-maven dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-spi-maven dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-impl-maven dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-bom](https://github.com/shrinkwrap/resolver) from 3.3.1 to 3.3.2. - [Release notes](https://github.com/shrinkwrap/resolver/releases) - [Commits](shrinkwrap/resolver@3.3.1...3.3.2) --- updated-dependencies: - dependency-name: org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps org.jruby:jruby-complete from 9.3.15.0 to 9.4.8.0. --- updated-dependencies: - dependency-name: org.jruby:jruby-complete dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.asciidoctor:asciidoctor-maven-plugin](https://github.com/asciidoctor/asciidoctor-maven-plugin) from 3.0.0 to 3.1.0. - [Release notes](https://github.com/asciidoctor/asciidoctor-maven-plugin/releases) - [Changelog](https://github.com/asciidoctor/asciidoctor-maven-plugin/blob/main/CHANGELOG.adoc) - [Commits](asciidoctor/asciidoctor-maven-plugin@asciidoctor-maven-tools-3.0.0...asciidoctor-maven-tools-3.1.0) --- updated-dependencies: - dependency-name: org.asciidoctor:asciidoctor-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.5.1 to 3.5.2. - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.5.1...surefire-3.5.2) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-surefire-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps org.jruby:jruby-complete from 9.4.8.0 to 9.4.9.0. --- updated-dependencies: - dependency-name: org.jruby:jruby-complete dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

This reverts commit 64e0cee.

pmd1nh · 2024-11-08T18:27:44Z

@markt-asf @gregw @olamy

pmd1nh · 2024-11-08T18:29:19Z

@pnicolucci

pnicolucci · 2024-11-08T18:46:46Z

Link to the TCK process: https://jakarta.ee/committees/specification/tckprocess/

I agree with @pmd1nh here that these changes should be reverted in the 6.1.1 Servlet TCK service release. The following challenge needs to be revisited: #525.

markt-asf · 2024-11-08T19:38:36Z

#680 is fine - it updated master. The issue is the cherry-picking of it into the 6.1.x branch in 1b90c29

markt-asf · 2024-11-08T19:39:08Z

This PR needs to be against 6.1.x, not master.

markt-asf

This PR needs to be against 6.1.x rather than master.

It should also add the @Ignore annotation to the challenged test.

pmd1nh · 2024-11-08T20:52:04Z

corrected branch to 6.1.X
added @Ignore to the flushBufferTest()

markt-asf

Note sure what you have done but there are way too many changes included.

pmd1nh · 2024-11-09T03:41:04Z

They show up after changing to the 6.1.X.

pmd1nh · 2024-11-11T00:45:52Z

closed in favor of #757

dependabot bot and others added 30 commits May 28, 2024 08:36

Fix table describing HttpMethodConstraint

bb680b8

Merge pull request #658 from jakartaee/dependabot/maven/org.apache.ma…

695fc55

…ven.plugins-maven-surefire-plugin-3.3.0

Version update: 6.1 -> 6.2

40d1588

Fix #616 - avoid NPE

45eddbb

Merge pull request #663 from markt-asf/fix-issue-616

795442b

Fix #616 - avoid NPE

Fix #615. Only API code should be in the jakarta package

e9f4f3d

Move unit tests to ee.jakarta

Use method that returns boolean rather than Boolean

04bbfb8

as TCK modules does not inherit servlet module, we need to setup some…

77c911b

… Maven plugins/configuration (#676) (#677) Signed-off-by: Olivier Lamy <[email protected]>

Merge pull request #678 from jakartaee/dependabot/maven/org.apache.ma…

87fcddf

…ven.plugins-maven-surefire-plugin-3.3.1

Merge pull request #679 from jakartaee/dependabot/maven/org.jboss.arq…

d8b3a70

…uillian-arquillian-bom-1.9.0.Final

Add new sendEarlyHints() method

0595445

Add jakarta.servlet.error.method to Table 10-1 and organize

8a4e970

dependabot bot and others added 14 commits October 21, 2024 23:18

Merge pull request #730 from jakartaee/dependabot/maven/master/org.ju…

c492837

…nit.jupiter-junit-jupiter-engine-5.11.3

Merge pull request #731 from jakartaee/dependabot/maven/master/org.ju…

72a5f06

…nit-junit-bom-5.11.3

Merge pull request #733 from jakartaee/dependabot/maven/master/org.ju…

603e4a3

…nit.jupiter-junit-jupiter-params-5.11.3

Merge pull request #732 from jakartaee/dependabot/maven/master/org.as…

8ca303e

…ciidoctor-asciidoctorj-pdf-2.3.19

[734] Add the AddFilterString to the deployment. (#735)

d8c2e08

Signed-off-by: James R. Perkins <[email protected]>

Fix javadoc

52b84e0

Update HttpServletRequestWrapper.java

c6354d1

Align copyright header with rest of project

Revert "Fix #525 FlushBufferTest (#680)"

5d81691

This reverts commit 64e0cee.

markt-asf requested changes Nov 8, 2024

View reviewed changes

pmd1nh changed the base branch from master to 6.1.x November 8, 2024 20:38

Update HttpServletResponseTests.java

d1a3a61

pmd1nh requested a review from markt-asf November 8, 2024 20:57

markt-asf requested changes Nov 8, 2024

View reviewed changes

pmd1nh changed the base branch from 6.1.x to 6.1.1-tck November 9, 2024 03:42

pmd1nh changed the base branch from 6.1.1-tck to 6.1.x November 9, 2024 03:43

pmd1nh closed this Nov 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Fix #525 FlushBufferTest" #756

Revert "Fix #525 FlushBufferTest" #756

pmd1nh commented Nov 8, 2024

pmd1nh commented Nov 8, 2024

pmd1nh commented Nov 8, 2024

pnicolucci commented Nov 8, 2024

markt-asf commented Nov 8, 2024

markt-asf commented Nov 8, 2024

markt-asf left a comment

pmd1nh commented Nov 8, 2024

markt-asf left a comment

pmd1nh commented Nov 9, 2024

pmd1nh commented Nov 11, 2024 •

edited

Loading

Revert "Fix #525 FlushBufferTest" #756

Revert "Fix #525 FlushBufferTest" #756

Conversation

pmd1nh commented Nov 8, 2024

pmd1nh commented Nov 8, 2024

pmd1nh commented Nov 8, 2024

pnicolucci commented Nov 8, 2024

markt-asf commented Nov 8, 2024

markt-asf commented Nov 8, 2024

markt-asf left a comment

Choose a reason for hiding this comment

pmd1nh commented Nov 8, 2024

markt-asf left a comment

Choose a reason for hiding this comment

pmd1nh commented Nov 9, 2024

pmd1nh commented Nov 11, 2024 • edited Loading

pmd1nh commented Nov 11, 2024 •

edited

Loading