From ed063213b37db2b4e08d392879062c0fd46ed484 Mon Sep 17 00:00:00 2001 From: Yuri Shkuro Date: Sun, 14 Jul 2024 16:33:11 -0400 Subject: [PATCH] add test Signed-off-by: Yuri Shkuro --- .../extension/remotesampling/config_test.go | 20 ++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/cmd/jaeger/internal/extension/remotesampling/config_test.go b/cmd/jaeger/internal/extension/remotesampling/config_test.go index 8f0d6ea8adb..c5071423c19 100644 --- a/cmd/jaeger/internal/extension/remotesampling/config_test.go +++ b/cmd/jaeger/internal/extension/remotesampling/config_test.go @@ -104,16 +104,18 @@ func Test_Unmarshal(t *testing.T) { expectedErr: "", }, { - name: "Empty config", - input: map[string]any{}, - expectedCfg: &Config{ - File: nil, - Adaptive: nil, - HTTP: nil, - GRPC: nil, - }, + name: "Empty config", + input: map[string]any{}, + expectedCfg: &Config{}, expectedErr: "", }, + { + name: "Invalid config", + input: map[string]any{ + "foo": "bar", + }, + expectedErr: "invalid keys: foo", // sensitive to lib implementation + }, } for _, tt := range tests { @@ -125,7 +127,7 @@ func Test_Unmarshal(t *testing.T) { require.NoError(t, err) assert.Equal(t, tt.expectedCfg, &cfg) } else { - assert.EqualError(t, err, tt.expectedErr) + assert.ErrorContains(t, err, tt.expectedErr) } }) }