From c4b54eed742d85b1169be9c7fdc6bf059fe6b73b Mon Sep 17 00:00:00 2001 From: Yuri Shkuro Date: Sun, 28 Jul 2024 17:08:54 -0400 Subject: [PATCH] comments Signed-off-by: Yuri Shkuro --- cmd/jaeger/internal/integration/kafka_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/cmd/jaeger/internal/integration/kafka_test.go b/cmd/jaeger/internal/integration/kafka_test.go index e3c25457c1e..b98eb3d819a 100644 --- a/cmd/jaeger/internal/integration/kafka_test.go +++ b/cmd/jaeger/internal/integration/kafka_test.go @@ -14,6 +14,11 @@ func TestKafkaStorage(t *testing.T) { // TODO these config files use topic: "jaeger-spans", // but for integration tests we want to use random topic in each run. + // https://github.com/jaegertracing/jaeger/blob/ed5cc2981c34158d0650cb96cb2fafcb753bea70/plugin/storage/integration/kafka_test.go#L50-L51 + // Once OTEL Collector supports default values for env vars + // (https://github.com/open-telemetry/opentelemetry-collector/issues/5228) + // we can change the config to use topic: "${KAFKA_TOPIC:-jaeger-spans}" + // and export a KAFKA_TOPIC var with random topic name in the tests. collectorConfig := "../../collector-with-kafka.yaml" ingesterConfig := "../../ingester-remote-storage.yaml"