Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: jaeger-operator v1.57.0 query.base-path is broken when strategy is production and storage.type is memory #2593

Open
yanqi27 opened this issue Jun 3, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@yanqi27
Copy link

yanqi27 commented Jun 3, 2024

What happened?

I tried to deploy a jaeger instance with strategy=production and custom query.base-path.

apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: jaeger
spec:
  strategy: production
  query:
    options:
      query:
        base-path: /jaeger

I couldn't access the query UI through web browser. I notice two things that may explain why it doesn't work.
[1] The jaeger container command argument misses --query.base-path=/jaeger.

...
spec:
  containers:
  - args:
    - --sampling.strategies-file=/etc/jaeger/sampling/sampling.json
    env:
    - name: SPAN_STORAGE_TYPE
      value: memory

[2] The ingress doesn't have the expected rules for path=/jaeger.

...
spec:
  defaultBackend:
    service:
      name: jaeger-query
      port:
        number: 16686

Steps to reproduce

  1. kubectl apply -f jaeger.yaml (contents shown in the above section)
  2. review the generated deployment and ingress. (also shown in the above section)

Expected behavior

The command argument includes --query.base-path=/jaeger

Relevant log output

No response

Screenshot

No response

Additional context

No response

Jaeger backend version

No response

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

No response

Deployment configs

No response

@yanqi27 yanqi27 added the bug Something isn't working label Jun 3, 2024
@iblancasa
Copy link
Collaborator

Hi @yanqi27. Thanks for reporting. Would you like to send a pull request?

@yanqi27 yanqi27 changed the title [Bug]: jaeger-operator v1.57.0 query.base-path is broken when strategy is production [Bug]: jaeger-operator v1.57.0 query.base-path is broken when strategy is production and storage.type is memory Jun 3, 2024
@yanqi27
Copy link
Author

yanqi27 commented Jun 3, 2024

@iblancasa
This happens only for storage.type==memory from my test. Therefore, it might be a minor issue. Though I am interested in fixing it, I am not familiar with the repo and I am currently tied with other works.

@mlucic
Copy link

mlucic commented Aug 29, 2024

I am experiencing the same problem even with the default strategy (all-in-one), query base path is not being set therefore the UI is not working since it is trying to pull the static files from the wrong path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants