Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove build fn w/ oneshot argument #27

Merged
merged 1 commit into from
Aug 2, 2023
Merged

refactor: remove build fn w/ oneshot argument #27

merged 1 commit into from
Aug 2, 2023

Conversation

jacobkaufmann
Copy link
Owner

remove Job::build function with oneshot::Sender argument, and use the task::JoinHandle from the spawned payload build task to manage pending payloads.

@jacobkaufmann jacobkaufmann merged commit 48dee59 into master Aug 2, 2023
1 check passed
@jacobkaufmann jacobkaufmann deleted the rm-build-w-channel branch August 12, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jacobkaufmann