Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More matroska support and .TS mpeg support #69

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gandji
Copy link

@gandji gandji commented Apr 5, 2020

Hi, I love and use simplemagic, brings some of the power of linux to java.
For my own projects I added the file types I needed (in magic.gz file):

  • some matroska files were not detected as such
  • some .ts (mpeg stream) files were not detected as such
    I added 2 unit tests with small files.
    Integration in official simplemagic would make my life easier maintenance-wise.
    Cheers,
    G.

Copy link
Owner

@j256 j256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the change to the magic.gz? Add it instead as lines to the src/test/resources/magic file.

@@ -40,6 +40,8 @@
*/
private FileType[] fileTypes = new FileType[] { //
//
new FileType("/files/x.mkv", ContentType.MATROSKA, "matroska", "video/x-matroska",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to the end of the list? I'd like to keep these in time order.

@j256
Copy link
Owner

j256 commented Oct 5, 2020

Thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants