Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to show/hide Account ID #458

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Option to show/hide Account ID #458

merged 6 commits into from
Sep 17, 2024

Conversation

jurajhilje
Copy link
Member

PR type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

@jurajhilje jurajhilje assigned gorkapernas and unassigned jurajhilje Sep 10, 2024
@gorkapernas
Copy link
Member

Verified on version 2.12.4 (6), @jurajhilje there is one issue, when bringing the app to the background and reopening it, the blur effect is replaced by a graphical block. See screenshot below.
account blur effect_block

Also, the desktop apps will include the "crossed eye" icon in the QR code, ideally we should have the same implementation across all platforms. Can you please confirm the expected design for this feature?

@jurajhilje
Copy link
Member Author

jurajhilje commented Sep 11, 2024

@gorkapernas New build is available - 2.12.4 (7). The UI issue with opening the app from sleep with hidden account ID should be fixed.

Regarding the "eye" icon over the QR code, I don't want to add this, as it will clutter the already packed UI further, so I want to keep the UI as clean as possible, as there's already the "eye" button just next to the QR code.

@jurajhilje jurajhilje assigned gorkapernas and unassigned jurajhilje Sep 11, 2024
@gorkapernas
Copy link
Member

Verified on 2.12.4 (8), all the issues have been fixed. This is good to go.

@jurajhilje jurajhilje merged commit f2b7dd3 into develop Sep 17, 2024
3 checks passed
@jurajhilje jurajhilje deleted the feature/hide-account-id branch September 17, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants